Skip to content

Commit

Permalink
[nathelper]updated fix_nated_contact() documentation
Browse files Browse the repository at this point in the history
Document that changes related to the contact made by
fix_nated_contact() are lost in the resume route called after an
async function is used.
  • Loading branch information
ionutrazvanionita committed Mar 8, 2016
1 parent e403a2b commit b68c9b9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions modules/nathelper/README
Expand Up @@ -370,6 +370,10 @@ modparam("nathelper", "max_pings_lost", 5)
address:port. If a list of URI parameter is provided, it will
be added to the modified contact;

IMPORTANT NOTE: Changes made by this function shall not be seen
in the async resume route. So make sure you call it in all the
resume routes where you need the contact fixed.

This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE,
BRANCH_ROUTE.

Expand Down
5 changes: 5 additions & 0 deletions modules/nathelper/doc/nathelper_admin.xml
Expand Up @@ -475,6 +475,11 @@ modparam("nathelper", "max_pings_lost", 5)
be added to the modified contact;
</para>
<para>
<emphasis>IMPORTANT NOTE: </emphasis> Changes made by this function shall
not be seen in the async resume route. So make sure you call it in all the
resume routes where you need the contact fixed.
</para>
<para>
This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE, BRANCH_ROUTE.
</para>
<example>
Expand Down

0 comments on commit b68c9b9

Please sign in to comment.