tm: simplify the fix in commit 82b8d20

Just unref the transactions and avoid the extra checks done by do_t_cleanup().
OpenSIPS · Nov 24, 2020 · e8a7cad · e8a7cad
1 parent 357a3ae
commit e8a7cad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/modules/tm/cluster.c b/modules/tm/cluster.c
@@ -36,8 +36,6 @@ static str tm_repl_cap = str_init("tm-repl");
 
 struct clusterer_binds cluster_api;
 
-int do_t_cleanup( struct sip_msg *req, void *bar);
-
 #define TM_BIN_POP(_t, _f, _d) \
 	do { \
 		if (bin_pop_##_t(packet, _f) < 0) { \
@@ -155,7 +153,11 @@ static void tm_repl_cancel(bin_packet_t *packet, str *buf, struct receive_info *
 		LM_ERR("cannot handle auto-CANCEL for %p!\n", t);
 
 cleanup:
-	do_t_cleanup(&msg, NULL);
+	t_unref_cell(t);
+
+	if ((t=get_t()) != NULL && t != T_UNDEFINED)
+		t_unref_cell(t);
+
 	free_sip_msg(&msg);
 }
 

diff --git a/modules/tm/tm.c b/modules/tm/tm.c
@@ -667,7 +667,7 @@ int load_tm( struct tm_binds *tmb)
 }
 
 
-int do_t_cleanup( struct sip_msg *req, void *bar)
+static int do_t_cleanup( struct sip_msg *req, void *bar)
 {
 	struct cell *t;