Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

presence bug #112

Closed
nikbyte opened this issue Oct 28, 2013 · 2 comments
Closed

presence bug #112

nikbyte opened this issue Oct 28, 2013 · 2 comments
Assignees
@bogdan-iancu
Labels
bug
Milestone
1.11.9

Comments

@nikbyte
Copy link
Member

nikbyte commented Oct 28, 2013

Sometimes we loose record in active_watchers table because we delete it before update to actual expire time. Need just to execute delete on db after insert/updates.
@nikbyte
Copy link
Member Author

nikbyte commented Jan 30, 2014

The same patch upload earlier by another user.

@nikbyte nikbyte closed this as completed Jan 30, 2014
@bogdan-iancu bogdan-iancu reopened this Mar 5, 2014
bogdan-iancu added a commit that referenced this issue Mar 10, 2014
@bogdan-iancu
When updating the database records, first perform all update and inse…
3c1164a 
…rts and then check the timeout for expired records -> records to be deleted.

Doing first the delete may hide records "expired but to be updated".
Credits go to Nick Altmann
Closes bug #112.
bogdan-iancu added a commit that referenced this issue Mar 10, 2014
@bogdan-iancu
When updating the database records, first perform all update and inse…
916f3ee 
…rts and then check the timeout for expired records -> records to be deleted.

Doing first the delete may hide records "expired but to be updated".
Credits go to Nick Altmann
Closes bug #112.

(cherry picked from commit 3c1164a)
bogdan-iancu added a commit that referenced this issue Mar 10, 2014
@bogdan-iancu
When updating the database records, first perform all update and inse…
f2286d3 
…rts and then check the timeout for expired records -> records to be deleted.

Doing first the delete may hide records "expired but to be updated".
Credits go to Nick Altmann
Closes bug #112.

(cherry picked from commit 3c1164a)
(cherry picked from commit 916f3ee)
@bogdan-iancu bogdan-iancu added this to the 1.11 milestone Mar 10, 2014
@bogdan-iancu bogdan-iancu self-assigned this Mar 10, 2014
bogdan-iancu added a commit that referenced this issue Mar 10, 2014
@bogdan-iancu
When updating the database records, first perform all update and inse…
169329a 
…rts and then check the timeout for expired records -> records to be deleted.

Doing first the delete may hide records "expired but to be updated".
Credits go to Nick Altmann
Closes bug #112.

(cherry picked from commit 3c1164a)
(cherry picked from commit 916f3ee)
@bogdan-iancu
Copy link
Member

Thank you @nikbyte for the report and for the patch you provided.

@bogdan-iancu bogdan-iancu mentioned this issue Mar 10, 2014
Merged
wdoekes pushed a commit to wdoekes/opensips that referenced this issue Sep 16, 2015
@bogdan-iancu @wdoekes
gn: Cherry pick 3c1164a.
49323c6 
(from branch master)

When updating the database records, first perform all update and inserts
and then check the timeout for expired records -> records to be deleted.
Doing first the delete may hide records "expired but to be updated".
Credits go to Nick Altmann Closes bug OpenSIPS#112.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogdan-iancu bogdan-iancu

Labels
bug
Projects
None yet
Milestone
1.11.9
Development

No branches or pull requests
2 participants
@nikbyte @bogdan-iancu