Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve event handling identification #1533

Open
razvancrainea opened this issue Nov 15, 2018 · 4 comments
Open

Improve event handling identification #1533

razvancrainea opened this issue Nov 15, 2018 · 4 comments
Assignees
@razvancrainea
Labels
high-priority improvement

Comments

@razvancrainea
Copy link
Member

razvancrainea commented Nov 15, 2018 •
edited

Currently each event_* module needs to register a hard-coded unique flag to the event interface in order to identify its sockets. Since this event is hard-coded, this method is very prone to errors (see this thread and 8bbc185), we need a way to improve the way we allocate these ids.

Thanks go to SamyGo on the mailing list for reporting this!
@razvancrainea razvancrainea self-assigned this Nov 15, 2018
@goharahmed
Copy link

Hi there,
An improvement is a long term solution, any possible value of that flag (as you recommend) to use in current situation to get this working?
Thanks

@razvancrainea
Copy link
Member Author

@goharahmed somehow my initial commit SHA was pointing to a different commit.
8bbc185 should have already solve this issue, but only temporarily.

@vitalikvoip
Copy link

(1<<25) is already busy by the event_routing module. The closest free flag is <<23.

razvancrainea added a commit that referenced this issue Dec 3, 2018
@razvancrainea
event_jsonrpc: fix yet busy flag value
84bf5f3 
This time the flag was overlapping with event_flatstore one. More
details in #1533
razvancrainea added a commit that referenced this issue Dec 3, 2018
@razvancrainea
event_jsonrpc: fix yet busy flag value
a1fdfcb 
This time the flag was overlapping with event_flatstore one. More
details in #1533

(cherry picked from commit 84bf5f3)
@razvancrainea
Copy link
Member Author

Yeah, this happened again, 25 was already overlapping with event_flatstore. This definitely needs to move to an error prone mechanism, I am increasing its priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razvancrainea razvancrainea

Labels
high-priority improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@razvancrainea @goharahmed @vitalikvoip