Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformations should not share the same buffer #1572

Closed
razvancrainea opened this issue Dec 18, 2018 · 2 comments
Closed

Transformations should not share the same buffer #1572

razvancrainea opened this issue Dec 18, 2018 · 2 comments
Assignees
@liviuchircu
Labels
bug high-priority
Milestone
3.0.5

Comments

@razvancrainea
Copy link
Member

Currently, most of the transformations share the same buffer for their output (_tr_buffer), or use a buffer that becomes shared (_ip_addr_A_buff in case of ip.ntop transformation). This leads to an undefined behavior when chaining multiple transformations, or when comparing the output of a transformation (see #1568).

An idea to fix this is to attach a special buffer to the variable's spec, that can be used by any transformation in the chain.
@razvancrainea razvancrainea added this to the 3.0 milestone Dec 18, 2018
@razvancrainea razvancrainea mentioned this issue Dec 18, 2018
Closed
@vasilevalex vasilevalex mentioned this issue Feb 1, 2019
Closed
@stale
Copy link

stale bot commented Jun 18, 2019

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@stale stale bot added the stale label Jun 18, 2019
@vasilevalex
Copy link
Contributor

It's important to implement. This is the source of not obvious mistakes in config script.

@stale stale bot removed the stale label Jun 20, 2019
@liviuchircu liviuchircu self-assigned this Jun 21, 2019
liviuchircu added a commit that referenced this issue Sep 30, 2019
@liviuchircu
Transformations: Fix a series of buffer overrun bugs
6dbf27a 
This patch adds several buffers, on two layers, such that the following
operations are no longer broken (i.e. leading to buffer overruns and
incorrect results):

    * putting together any kind of transformation chain without the risk
      of reading and writing into the same transformation buffer

    * passing multiple transformation-enabled variables with arbitrary
      chaining lengths to a script function without the risk of any two
      of them making use of the same buffer

Many thanks to Răzvan Crainea for some timely tips!

Fixes #1572

(cherry picked from commit 25c7c59)
liviuchircu added a commit that referenced this issue Sep 30, 2019
@liviuchircu
Transformations: Fix a series of buffer overrun bugs
f4f5f8d 
This patch adds several buffers, on two layers, such that the following
operations are no longer broken (i.e. leading to buffer overruns and
incorrect results):

    * putting together any kind of transformation chain without the risk
      of reading and writing into the same transformation buffer

    * passing multiple transformation-enabled variables with arbitrary
      chaining lengths to a script function without the risk of any two
      of them making use of the same buffer

Many thanks to Răzvan Crainea for some timely tips!

Fixes #1572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liviuchircu liviuchircu

Labels
bug high-priority
Projects
None yet
Milestone
3.0.5
Development

No branches or pull requests
4 participants
@razvancrainea @bogdan-iancu @liviuchircu @vasilevalex