Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Does not terminate the call upon re-invite pings failure #1797

Closed
ryanembregts opened this issue Aug 9, 2019 · 5 comments
Closed

[BUG] Does not terminate the call upon re-invite pings failure #1797

ryanembregts opened this issue Aug 9, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@ryanembregts
Copy link

I trying to have opensips terminate the call upon re-invite pings failure. But I have got no success so far. In the debug logs i see

Aug 9 17:49:08 debian ./opensips[18710]: INFO:dialog:dlg_handle_seq_reply: terminating dialog ( due to 481 ) with callid = [7afc1a63843971c87b9733f6d25d6f18@0:0:0:0:0:0:0:0]

But a Bye is never sent.

Below is how i am calling the function.

create_dialog("BrR");

Does not terminate call

version: opensips 3.0.0 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, HP_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535 poll method support: poll, epoll, sigio_rt, select. git revision: f1e28a5 main.c compiled on 14:28:14 Aug 9 2019 with gcc 6.3.0`

@bogdan-iancu
Copy link
Member

@ryanembregts , do you use any clustering support (and sharing tags) with the dialog module ?

@ryanembregts
Copy link
Author

@bogdan-iancu Thanks for the reply. Nope, i am not using any kind of clustering or profile sharing. This is standalone server. I can provide debug logs if that helps. :)

@stale
Copy link

stale bot commented Aug 29, 2019

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@stale stale bot added the stale label Aug 29, 2019
@liviuchircu liviuchircu self-assigned this Sep 12, 2019
@stale stale bot removed the stale label Sep 12, 2019
@liviuchircu liviuchircu added this to the 2.4.7 milestone Sep 12, 2019
@liviuchircu
Copy link
Member

Confirming this issue. It seems to be caused by a poorly set boolean field, a fix will be available soon.

@liviuchircu
Copy link
Member

liviuchircu commented Sep 12, 2019

Actually, it seems to be a Re-INVITE pinging regression (the OPTIONS ping dialog termination still works fine), caused by 0d026b9. As the pinging functions have been merged, the reinvite_confirmed field has been lost in transit.

liviuchircu added a commit that referenced this issue Sep 12, 2019
Commit 0d026b9 introduced a regression where the Re-INVITE pinging
timeouts would not work anymore.

Fixes #1797

(cherry picked from commit 295f4ba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants