Error in the logs while looking for contact param when param missing

[ovidiusas]

Easy to reproduce with the following probe:

xlog("L_NOTICE", "$(ct{param.value,blah})\n");


ERROR:core:parse_params: invalid character, ; expected, found <


This is specific to Contact header only. Trying to retrieve a bogus param from to or from header does not produce an error in the logs.

[liviuchircu]

Ovidiu,

That's because "param.value" requires formatted input. Try using $(ct{nameaddr.params}{param.value,blah})

[ovidiusas]

xlog("L_NOTICE", "$(ct{nameaddr.params}{param.value,blah})\n"); leads to: ERROR:core:parse_param_body: failed to parse quoted string ERROR:core:parse_params: failed to parse param body

[ovidiusas]

The problem is depicted more clearly here:

xlog("L_NOTICE", "$$ct=[$ct]\n");


$var(ct_nameaddr_params) = $(ct{nameaddr.params});


xlog("L_NOTICE", "$$var(ct_nameaddr_params)=[$var(ct_nameaddr_params)]\n");


Leads to the following output:

$ct=["test" sip:test@192.168.2.113:53814;ob;reg-id=1;+sip.instance="urn:uuid:ed409b05-1872-36ee-8ba0-865cb642250b"]


$var(ct_nameaddr_params)=[reg-id=1;+sip.instance="urn:uuid:ed409b05-1872-36ee-8ba0-865cb642250b]


The last <"> char is lost during the nameaddr.params transformation.

[bogdan-iancu]

@ovidiusas , according to the RFC3261 grammar , the contact body
["test" sip:test@192.168.2.113:53814;ob;reg-id=1;+sip.instance="urn:uuid:ed409b05-1872-36ee-8ba0-865cb642250b"]
is not valid. If display name is present, the URI must be enclosed between angle brackets (see page 227 in the RFC):

Contact = ("Contact" / "m" ) HCOLON
( STAR / (contact-param *(COMMA contact-param)))
contact-param = (name-addr / addr-spec) *(SEMI contact-params)
name-addr = [ display-name ] LAQUOT addr-spec RAQUOT
addr-spec = SIP-URI / SIPS-URI / absoluteURI
display-name = *(token LWS)/ quoted-string

So, the correct format should be :
["test" sip:test@192.168.2.113:53814;ob;reg-id=1;+sip.instance="urn:uuid:ed409b05-1872-36ee-8ba0-865cb642250b"]

[ovidiusas]

The formatting was messed up by github :(
Here's the correct header that failed to be parsed

$ct=["test" <sip:test@192.168.2.113:34184;transport=TCP;ob>;reg-id=1;+sip.instance="<urn:uuid:ed409b05-1872-36ee-8ba0-865cb642250b>"]
$var(ct_nameaddr_params)=[reg-id=1;+sip.instance="<urn:uuid:ed409b05-1872-36ee-8ba0-865cb642250b>]

The header is properly formated:

Contact:"test" <sip:test@192.168.2.113:34184;transport=TCP;ob>;reg-id=1;+sip.instance="<urn:uuid:ed409b05-1872-36ee-8ba0-865cb642250b>"

[bogdan-iancu]

@ovidiusas , thanks for the hints, I found and fix the bug - it was related to having a quoted value in the last hdr param (problem was in the nameaddr transformation, for "params").

Btw, instead of
$(ct{nameaddr.params}{param.value,blah})
you can simpler do:
$(ct{nameaddr.param,blah})
It is much more efficient :)

[ovidiusas]

Something is not right again (latest 1.11).

        xlog("L_NOTICE", "$$ct=[$ct]\n");
        xlog("L_NOTICE", "$$ct.fields(params)=[$ct.fields(params)]\n");
        xlog("L_NOTICE", "$$(ct{nameaddr.params})=[$(ct{nameaddr.params})]\n");

generates:

$ct=["test" <sip:test@192.168.2.113:46466;transport=TCP>;+sip.ice]
$ct.fields(params)=[+sip.ice]
ERROR:core:pv_printf: no more space for spec value [24][559214942]
ERROR:core:pv_printf: buffer overflow -- increase the buffer size from [4096]...
ALERT:core:do_action: Cannot print xlog debug message

[bogdan-iancu]

It was a different case, when the last parameter has no value. It is fixed now. Thanks, Bogdan