-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] rtpengine module parse_flags error #2692
Comments
copy form wireshark
|
i use rtpengine_offer("media-address=...."), but from the packet , opensips not use the "media-address" as param to send to rtpengine |
There is indeed a bug regarding the |
Thanks go to @wangduanduan for reporting it in #2692
Thanks go to @wangduanduan for reporting it in #2692 (cherry picked from commit 7411e62)
Thanks go to @wangduanduan for reporting it in #2692
Thanks go to @wangduanduan for reporting it in #2692 (cherry picked from commit 83e0bf6)
not only the media-addres, may be all break and continue is wrong. all continue and break should switch their position. please check this. case 3:
if (str_eq(&key, "RTP")) {
ng_flags->transport |= 0x100;
ng_flags->transport &= ~0x001;
}
else if (str_eq(&key, "AVP")) {
ng_flags->transport |= 0x100;
ng_flags->transport &= ~0x002;
} else
continue;
break;
case 4:
if (str_eq(&key, "SRTP"))
ng_flags->transport |= 0x101;
else if (str_eq(&key, "AVPF"))
ng_flags->transport |= 0x102;
else
continue;
break;
... if continue is last, the blow is never be exected, it will continue next loop. /* we got here if we didn't match something specific */
if (!val.s) {
bitem = bencode_str(bencode_item_buffer(ng_flags->flags), &key);
if (!bitem) {
err = "no more memory";
goto error;
}
BCHECK(bencode_list_add(ng_flags->flags, bitem));
} else {
bitem = bencode_str(bencode_item_buffer(ng_flags->dict), &val);
if (!bitem) {
err = "no more memory";
goto error;
}
BCHECK(bencode_dictionary_add_len(ng_flags->dict, key.s, key.len, bitem));
} |
Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days. |
Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details. |
IMO the |
Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days. |
Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details. |
OpenSIPS version you are running
Describe the bug
opensips rtpengine bencode encode error, below is a packet from opensips to rtpeinge
request-to-rtpengine.pcap.zip
The text was updated successfully, but these errors were encountered: