Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] debian package builder fails when pkg build limit list does not include BERKELEY #3389

Closed
rrevels-bw opened this issue May 16, 2024 · 3 comments
Assignees

Comments

@rrevels-bw
Copy link

rrevels-bw commented May 16, 2024

OpenSIPS version you are running

opensips_3.2.18-1  (no running install yet)

Describe the bug

When using a limited package build list that does not include BERKELEY like this:
make deb DEBBUILD_EXTRA_OPTIONS="-uc -us" INSTALL_PREFIX='/usr/local/opensips' BUILD_MODPKG_LIST='MYSQL RADIUS REGEX DIALPLAN JSON HTTP REST_CLIENT PROMETHEUS KAFKA'

the package build process fails with:

# move binaries of opensips-berkeley-module to opensips-berkeley-bin
mkdir -p /opt/build/opensips/debian/opensips-berkeley-bin//usr/local/opensips/
mv /opt/build/opensips/debian/opensips-berkeley-module//usr/local/opensips/sbin \
	/opt/build/opensips/debian/opensips-berkeley-bin//usr/local/opensips/
mv: cannot stat '/opt/build/opensips/debian/opensips-berkeley-module//usr/local/opensips/sbin': No such file or directory
make[2]: *** [debian/rules:365: override_dh_auto_install] Error 1

This does not happen if BERKELEY is added to the list

To Reproduce

  1. git clone https://github.com/OpenSIPS/opensips.git -b 3.2
  2. cd opensips/
  3. make deb-orig-tar
  4. make deb DEBBUILD_EXTRA_OPTIONS="-uc -us" INSTALL_PREFIX='/usr/local/opensips' BUILD_MODPKG_LIST='MYSQL RADIUS REGEX DIALPLAN JSON HTTP REST_CLIENT PROMETHEUS KAFKA'

Expected behavior

build doesnt fail

Relevant System Logs

OS/environment information

  • Operating System: Debian 12.5
  • OpenSIPS installation:
  • other relevant information:

Additional context

This isn't a bug but I'm also wondering if there is a make command line option to instruct the deb build process to give me the single package with all modules built included or i have to modify the rules and control files and such.

Copy link

github-actions bot commented Jun 1, 2024

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

@github-actions github-actions bot added the stale label Jun 1, 2024
@razvancrainea
Copy link
Member

@rrevels-bw you're right, if the Berkeley packages are not built, they should not interfere with the other packages.
I will soon push a fix for this on all branches.

@razvancrainea razvancrainea self-assigned this Jun 13, 2024
@stale stale bot removed stale labels Jun 13, 2024
razvancrainea added a commit that referenced this issue Jun 13, 2024
If the berkeley package is not build, we should not run its stubs, as
they result in errors.

Thanks go to Richard Revels (@rrevels-bw on GitHub) for reporting it.
Close #3389

(cherry picked from commit 2fba04a)
razvancrainea added a commit that referenced this issue Jun 13, 2024
If the berkeley package is not build, we should not run its stubs, as
they result in errors.

Thanks go to Richard Revels (@rrevels-bw on GitHub) for reporting it.
Close #3389

(cherry picked from commit 2fba04a)
razvancrainea added a commit that referenced this issue Jun 13, 2024
If the berkeley package is not build, we should not run its stubs, as
they result in errors.

Thanks go to Richard Revels (@rrevels-bw on GitHub) for reporting it.
Close #3389

(cherry picked from commit 2fba04a)
@rrevels-bw
Copy link
Author

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants