Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds_is_in_list: not possible to check all sets for active destinations #389

Closed
gergelypeli opened this issue Nov 26, 2014 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@gergelypeli
Copy link

Dispatcher's ds_is_in_list function takes up to four arguments, the third one specifying the destination set to check, and the fourth one if to check active destinations only. If both are omitted, the third "set" argument is implicitly set to -1, and it checks all sets. However, if the fourth "active_only" argument is given, then the third argument is parsed as an unsigned integer (in "in_list_fixup"), which makes it impossible to check more than one set.

There should be a way to specify "check all destination sets" even if the fourth argument is given.

@bogdan-iancu
Copy link
Member

Hi @gergelypeli , changing in in_list_fixup, for the third param, from fixup_unit() ro fixup_sint() [line 785], does the trick for you ?

@bogdan-iancu bogdan-iancu self-assigned this Dec 12, 2014
@bogdan-iancu bogdan-iancu added this to the 1.11 milestone Dec 12, 2014
@gergelypeli
Copy link
Author

It should :-). But then the docs should mention that specifying "-1" means "all sets", as this is not something that people would figure out.

razvancrainea added a commit that referenced this issue Dec 15, 2014
razvancrainea added a commit that referenced this issue Dec 15, 2014
razvancrainea added a commit that referenced this issue Dec 15, 2014
Closes #389

(cherry picked from commit 3729bad)
razvancrainea added a commit that referenced this issue Dec 15, 2014
Closes #389

(cherry picked from commit 3729bad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants