Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PUA module so that it sends a final PUBLISH on expiration. #16

Closed
wants to merge 1 commit into from

Conversation

dsandras
Copy link
Contributor

A final PUBLISH with expires=0 is now generated when a publication
has expired. This will trigger the transmission of a final state NOTIFY.

If accepted, please credit Damien Sandras from Be IP s.a. @ http://www.beip.be

@ghost ghost assigned saghul Jul 16, 2013
@dsandras
Copy link
Contributor Author

From my point of view, the correct fix is to:

  1. Send a final PUBLISH
  2. Delete the item from the hash table
    I have double checked all of this and can confirm my pull request works as it should.

@saghul
Copy link
Member

saghul commented Sep 13, 2013

LGTM, can you please squash the commits into one?

@dsandras
Copy link
Contributor Author

Sure. I'll do it before the end of the day and generate a new pull request.

@saghul
Copy link
Member

saghul commented Sep 13, 2013

Great! No need to create a new one, just force push (push -f) to the branch where you made the request from.

A final PUBLISH with expires=0 is now generated when a publication has
expired. This will trigger the transmission of a final state NOTIFY.
@dsandras
Copy link
Contributor Author

I think it is now like you want it :)

Damien

@saghul
Copy link
Member

saghul commented Sep 13, 2013

Yep, thanks! I'll try to merge it later today, first on master and then backport it down to 1.8 (can you confirm, @bogdan-iancu ?). Hopefully there are no conflicts :-)

@saghul
Copy link
Member

saghul commented Sep 17, 2013

Thanks, Damien! It landed on c5a57a8, 763ea32, f986bac and c2202a0

@dsandras
Copy link
Contributor Author

dsandras commented Oct 7, 2013

Thanks !

@dsandras dsandras deleted the ds-fix-final-publish branch October 7, 2013 11:59
@mnunzi mnunzi mentioned this pull request Nov 7, 2013
@apsaras apsaras mentioned this pull request Mar 26, 2014
@ankogan ankogan mentioned this pull request Feb 6, 2016
@apsaras apsaras mentioned this pull request Mar 5, 2016
@caloveri caloveri mentioned this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants