-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PUA module so that it sends a final PUBLISH on expiration. #16
Conversation
From my point of view, the correct fix is to:
|
LGTM, can you please squash the commits into one? |
Sure. I'll do it before the end of the day and generate a new pull request. |
Great! No need to create a new one, just force push (push -f) to the branch where you made the request from. |
A final PUBLISH with expires=0 is now generated when a publication has expired. This will trigger the transmission of a final state NOTIFY.
I think it is now like you want it :) Damien |
Yep, thanks! I'll try to merge it later today, first on master and then backport it down to 1.8 (can you confirm, @bogdan-iancu ?). Hopefully there are no conflicts :-) |
Thanks ! |
A final PUBLISH with expires=0 is now generated when a publication
has expired. This will trigger the transmission of a final state NOTIFY.
If accepted, please credit Damien Sandras from Be IP s.a. @ http://www.beip.be