presence_dialoginfo: Fix memory leak in dlginfo_agg_nbody.

[wdoekes]

This commit fixes a couple of presence issues (introduced in 80c48e6):

• There was a memory leak in dlginfo_agg_nbody.
• Bounds checking in dlginfo_agg_nbody was off by 4 (potential stack
  corruption).
• There were 2 PKG allocs, straight after one another while no alloc
  was needed at all: reduced to 1 optional one.
• Replace "dumy" with "dummy" in the vicinity.

[wdoekes]

(I squashes the two commits into one, just now.)

[bogdan-iancu]

Many thanks @wdoekes for this fix !

[dsandras]

Hi,

The leak was fixed in my local branch, and I apparently forgot to push it. Apologies.

About the bound checking error, the code was cut&pasted from another place in the same file where the same error is still present:

Line 165:
/* create the new NOTIFY body */
if ( (pres_user->len + pres_domain->len + 1) > MAX_URI_SIZE) {
LM_ERR("entity URI too long, maximum=%d\n", MAX_URI_SIZE);
return NULL;
}

[bogdan-iancu]

Hi @dsandras , could you also confirm that the applied patch fixes the mem leaks you are aware about ?

Thanks and regards,
Bogdan

[dsandras]

Hi,

Yes. However, it seems to me that the probability for those leaks to
appear was very weak (only in case of error). The leak was on pres_user
not always being freed, which is not possible anymore as it is not
dynamically allocated anymore.

Le 12/03/14 21:59, Bogdan Andrei IANCU a écrit :

Hi @dsandras https://github.com/dsandras , could you also confirm
that the applied patch fixes the mem leaks you are aware about ?

Thanks and regards,
Bogdan

—
Reply to this email directly or view it on GitHub
#174 (comment).

---

Damien SANDRAS

Ekiga Project
http://www.ekiga.org