rtpengine: refactor of node probing #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probing of disabled rtpengine nodes is now done in timer routine instead of SIP context.
razvancrainea
requested changes
Aug 12, 2021
john08burke
force-pushed
the
rtpengine_probing_refactor
branch
from
959ed5a
to
dc4a2b9
Compare
razvancrainea
approved these changes
Aug 13, 2021
|
Thanks for the PR, John! The rtpproxy one is welcome as well, if you have time to take care of it :). |
|
Hey @razvancrainea, I will try to put a PR in for the rtpproxy module. I was first going to look into an additional PR for rtpengine, where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a slight refactor of the existing probing mechanism for disabled rtpengine nodes. Currently, probing is done within the SIP processing context. This can lead to excessive delay while processing SIP requests when 1+ nodes are down or unreachable. For example, theoretical max delay in SIP context is (
# down nodes) * (rtpengine_retr*rtpengine_tout) seconds everyrtpengine_disable_toutsecond interval when the down nodes are selected via weighting algorithm.This PR proposes to move the probing mechanism out of SIP context and into a timer routine that triggers every
rtpengine_timer_intervalsecond interval. This should eliminate delays associated with probing disabled rtpengine nodes.Let me know your thoughts! The same could likely be applied to the rtpproxy module, but I wanted to get feedback before refactoring rtpproxy.