fix calls per minute for fraud_detection module #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionutrazvanionita
force-pushed
the
master
branch
from
7975b8d
to
c357e61
Compare
Now the calls per minute parameter is build as consisting of an initial time(t0) and a 60 seconds window(as was before). Each window slot holds the calls received in that second(as before). The difference is that now these parameters are updated based on three conditions: * we receive the call between [t0; t0 + WINDOW_SIZE(60s)] - we only update the number of calls for that slot(t0 + current time) and the calls per minute parameter * we receive the call in the interval of [t0+WINDOW_SIZE; t0+2*WINDOW_SIZE] - we do the following: move t0 in current call time - WINDOW_SIZE, invalidate all the calls we knew of from t0 to current t0 (current call time - WINDOW_SIZE) * we receive a call after 2 * WINDOW_SIZE(60 seconds) + t0 - this invalidates all the calls we knew of since the window is not does not contains calls newer than the last 60 seconds;
ionutrazvanionita
force-pushed
the
master
branch
from
c357e61
to
dd25c63
Compare
liviuchircu
added a commit
that referenced
this pull request
Jan 12, 2016
fix calls per minute for fraud_detection module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the calls per minute parameter is build as consisting of an initial
time(t0) and a 60 seconds window(as was before). Each window slot holds the
calls received in that second(as before). The difference is that now
these parameters are updated based on three conditions:
the number of calls for that slot(t0 + current time) and the calls per minute
parameter
we do the following: move t0 in current call time - WINDOW_SIZE, invalidate
all the calls we knew of from t0 to current t0 (current call time - WINDOW_SIZE)
all the calls we knew of since the window is not does not contains calls newer
than the last 60 seconds;