SQL Cacher #676
Merged
SQL Cacher #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-use fetch_result for queries if sql db supports -fix cachedb encoding for null sql db values -caching id added in cachedb key
… optimize for next pvar get
|
Great work, Vlad! Looked through the commits, and reviewed each of them - you can find some of my own suggestions here |
-improved coding style -more verbose error messages -trim whitespaces for cache entry specification -fix memory leak: free temporary cache entries list used for parsing
-if table is empty don't return error when loading entire table -improve error reporting for cache_table parameter -cache entire table if no columns are specified -don't allocate new array of columns for sql query function call -fix memory leaks in insert_in_cachedb() -add columns_delimiter module parameter -update README
liviuchircu
added a commit
that referenced
this pull request
Dec 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New module sql_cacher