ASYNC_CHANGE_FD status + db engine async state parameter + db_virtual async #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionutrazvanionita
force-pushed
the
db_virtual_async
branch
from
eb89c09
to
855a5ce
Compare
ionutrazvanionita
force-pushed
the
db_virtual_async
branch
from
855a5ce
to
4ccc5e8
Compare
|
@liviuchircu , please review this patch |
| @@ -36,7 +36,8 @@ | |||
| * NOTE: all values in this enum must be negative | |||
| */ | |||
| enum async_ret_code { | |||
| ASYNC_NO_IO = -5, | |||
| ASYNC_NO_IO = -6, | |||
| ASYNC_CHANGE_FD, | |||
There was a problem hiding this comment.
I'd suggest moving ASYNC_CHANGE_FD two spots below, since it's still an async operation (but on a new DB backend/host), along with ASYNC_CONTINUE.
added 3 commits
February 18, 2016 11:55
Allows changing the file descriptor in the resume function. Such functionality is useful for failover purposes, like having multiple destinations, you find that one is not working only in the resume function and you want to try another one. Now you can change the file descriptor, remove the old one and add the new descriptor and then wait for it to be triggered.
Databases can now keep their state between the async call and the resume parameter using a newly added (void*) parameter. It is the job of the upper layer(the module calling the async function) to store this database state inside the (void*) parameter they are using to hold their state (see avpops and sipcapture async handling). Also this patch handles the new ASYNC_CHANGE_FD state in avpops and sipcapture.
ionutrazvanionita
force-pushed
the
db_virtual_async
branch
from
4ccc5e8
to
737ced7
Compare
liviuchircu
added a commit
that referenced
this pull request
Feb 19, 2016
ASYNC_CHANGE_FD status + db engine async state parameter + db_virtual async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the following: