Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify SLO AlertPolicy #133

Closed
ian-bartholomew opened this issue May 4, 2022 · 1 comment · Fixed by #144
Closed

Clarify SLO AlertPolicy #133

ian-bartholomew opened this issue May 4, 2022 · 1 comment · Fixed by #144
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ian-bartholomew
Copy link
Contributor

Summary

In the SLO section, alertPolicies are not defined as being either inlined or a reference. We should decide on one, and clarify it.

What is the expected correct behavior?

Have in the spec if the alertPolicies in the SLO kind is a reference, inlined, or both.
@ian-bartholomew ian-bartholomew added bug Something isn't working good first issue Good for newcomers labels May 4, 2022
@kenfinnigan
Copy link
Collaborator

It should align with the pattern for Indicator, AlertCondition, and AlertNotificationTarget. The AlertPolicy can be inlined or a reference

@kenfinnigan kenfinnigan mentioned this issue May 27, 2022
Open
kenfinnigan added a commit to kenfinnigan/OpenSLO that referenced this issue Jun 22, 2022
@kenfinnigan
Clarify SLO AlertPolicy
9780de8 
Fixes OpenSLO#133
@kenfinnigan kenfinnigan mentioned this issue Jun 22, 2022
Merged
programmer04 pushed a commit that referenced this issue Jun 22, 2022
@kenfinnigan
Clarify SLO AlertPolicy (#144)
f70bff1 
Fixes #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify SLO AlertPolicy kenfinnigan/OpenSLO
2 participants
@kenfinnigan @ian-bartholomew