allow for the inclusion of arbitrary key / value metadata #236
Conversation
When working with lots of SLO / SLI objects at scale, it can be helpful to be able to add arbitrary metadata to indicate things like: - ownership - association to certain projects - criticality or other ways that teams might need to organize their SLOs, SLIs, and Datasources. Allowing for key value pairs in the spec directly avoids having to do workarounds like depend on naming schemes. Some prior discussion is in OpenSLO#179
|
Some prior discussion is in #179 I was unsure of the best syntax to indicate an optional object of keys with string values, so I grabbed this based on the k8s CRD spec, but if something else is preferred let me know. |
|
additionally, having metadata in the |
|
@BertHartm you can open a separate PR for objectives' metadata, I think this suggestion also makes a lot of sense :) |
Thanks, filed #237 for that specifically |
nieomylnieja
added
the
v2alpha1
There was a problem hiding this comment.
On the last community meeting we've agreed on merging this to v2alpha :) thanks a lot for this contribution!
Side note: We also decided to change the labels to adhere with k8s schema, but this will get done in a different PR.
|
@BertHartm could please resolve the conflict? Thanks! |
updated, please review |
|
I think that this ties into the discussion around Kubernetes compatibility a bit. If we chose to use the Kubernetes |
|
@fourstepper, as discussed, let's merge it anyway and follow up with proposals of bringing metadata in sync with k8s metadata |
When working with lots of SLO / SLI objects at scale, it can be helpful to be able to add arbitrary metadata to indicate things like:
Allowing for key value pairs in the spec directly avoids having to do workarounds like depend on naming schemes.