Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long lines #683

Closed
poolpOrg opened this issue Apr 21, 2016 · 8 comments
Closed

long lines #683

poolpOrg opened this issue Apr 21, 2016 · 8 comments
Assignees

Comments

@poolpOrg
Copy link
Member

long lines have been a constant issue for users.

on one side, RFC provides SHOULD and MUST to determine what is an acceptable line size, on another hand being too strict with this has proved to break communications frequently.

we need to reassess how we're handling them.

@poolpOrg poolpOrg self-assigned this Oct 18, 2016
@poolpOrg
Copy link
Member Author

@ericfaurot is working on a new headers and message parser which will make it easier to handle long lines correctly.

to be followed...

@dgwynne
Copy link

dgwynne commented Feb 1, 2018

i just got bitten by some long lines other people were sending. who do i bribe for progress on this?

@poolpOrg
Copy link
Member Author

poolpOrg commented Feb 1, 2018

No bribing required, it' s taking time because it has a few tentacles and requires rewriting some tricky code... but it's almost done for real.

@poolpOrg
Copy link
Member Author

poolpOrg commented Feb 6, 2018

I'm preparing a quick fix to workaround and commit on Sunday.

@poolpOrg
Copy link
Member Author

poolpOrg commented Mar 7, 2018

we've bumped considerably the line limit, this should fix user issues but itś not the proper way to fix it which is still being worked on.

@poolpOrg poolpOrg added this to the OpenSMTPD 6.4.0 milestone Sep 1, 2018
@poolpOrg
Copy link
Member Author

poolpOrg commented Sep 1, 2018

@ericfaurot has committed a new message parser which can process long lines and which makes it possible to solve this ticket for good.

He is currently investigating if there are other areas that still work with long lines but we think there aren't and this ticket might be closed soon.

@poolpOrg
Copy link
Member Author

poolpOrg commented Sep 3, 2018

a diff is pending review by @ericfaurot to bump the maximum line size to 64k which is the limit imposed in lower level subsystems and which is a reasonnable high bound.

@poolpOrg
Copy link
Member Author

poolpOrg commented Sep 3, 2018

committed, so long nuisance.

@poolpOrg poolpOrg closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants