build: Fix -Werror=strict-prototypes #1198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2023
Clang-16 is more strict about these so make the compiler happy.
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 25, 2023
Closes: https://bugs.gentoo.org/899876 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/896050 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 25, 2023
Closes: https://bugs.gentoo.org/899876 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/896050 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 25, 2023
Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 25, 2023
Fixes the build on musl systems and uses AM_PROG_AR rather than a hard coded ar. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 25, 2023
Fixes the build on musl systems and uses AM_PROG_AR rather than a hard coded ar. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 25, 2023
Fixes the build on musl systems and uses AM_PROG_AR rather than a hard coded ar. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 25, 2023
Fixes the build on musl systems and uses AM_PROG_AR rather than a hard coded ar. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 26, 2023
Fixes some build issues: * Build failures on musl systems * Build issues with clang-16 * Uses AM_PROG_AR to find ar(1) during configure * Uses configure arguments to find libevent and libssl on multilib systems. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/739876 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 26, 2023
Fixes some build issues: * Build failure on musl systems * Build failure with clang-16 * Uses AM_PROG_AR to find ar(1) during configure * Uses configure arguments to find libevent and libssl on multilib systems. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/739876 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 26, 2023
Fixes some build issues: * Build failure on musl systems * Build failure with clang-16 * Uses AM_PROG_AR to find ar(1) during configure * Uses configure arguments to find libevent and libssl on multilib systems. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/739876 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Apr 26, 2023
Fixes some build issues: * Build failure on musl systems * Build failure with clang-16 * Uses AM_PROG_AR to find ar(1) during configure * Uses configure arguments to find libevent and libssl on multilib systems. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/739876 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Apr 26, 2023
Fixes some build issues: * Build failure on musl systems * Build failure with clang-16 * Uses AM_PROG_AR to find ar(1) during configure * Uses configure arguments to find libevent and libssl on multilib systems. Closes: https://bugs.gentoo.org/720782 Closes: https://bugs.gentoo.org/727260 Closes: https://bugs.gentoo.org/739876 Closes: https://bugs.gentoo.org/896050 Closes: https://bugs.gentoo.org/899876 Upstream-Issue: OpenSMTPD/OpenSMTPD#1065 Upstream-PR: OpenSMTPD/OpenSMTPD#1195 Upstream-PR: OpenSMTPD/OpenSMTPD#1198 Upstream-PR: OpenSMTPD/OpenSMTPD#1199 Signed-off-by: orbea <orbea@riseup.net> Closes: #30750 Signed-off-by: Sam James <sam@gentoo.org>
|
This is no longer necessary with the upstream sync done by @omar-polo with #1201 , care to confirm ? |
|
@poolpOrg Indeed, this is no longer needed. @omar-polo thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang-16 is more strict about these so make the compiler happy.
Split from PR #1195.