Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement editing family members #206

Merged
merged 13 commits into from
Jun 4, 2019
Merged

Implement editing family members #206

merged 13 commits into from
Jun 4, 2019

Conversation

githengi
Copy link
Contributor

PR for #183

@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@opensrp opensrp deleted a comment May 31, 2019
@coveralls
Copy link

coveralls commented May 31, 2019

Pull Request Test Coverage Report for Build 1415

  • 102 of 162 (62.96%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.09%) to 40.809%

Changes Missing Coverage Covered Lines Changed/Added Lines %
opensrp-reveal/src/main/java/org/smartregister/reveal/util/FamilyJsonFormUtils.java 72 80 90.0%
opensrp-reveal/src/main/java/org/smartregister/reveal/presenter/FamilyOtherMemberPresenter.java 29 39 74.36%
opensrp-reveal/src/main/java/org/smartregister/reveal/view/FamilyOtherMemberProfileActivity.java 0 42 0.0%
Files with Coverage Reduction New Missed Lines %
opensrp-reveal/src/main/java/org/smartregister/reveal/view/FamilyOtherMemberProfileActivity.java 2 0.0%
Totals Coverage Status
Change from base Build 1404: 1.09%
Covered Lines: 1543
Relevant Lines: 3781

💛 - Coveralls

@opensrp opensrp deleted a comment Jun 3, 2019
@opensrp opensrp deleted a comment Jun 3, 2019
@opensrp opensrp deleted a comment Jun 4, 2019
@githengi githengi merged commit b04b16f into master Jun 4, 2019
@githengi githengi deleted the 183-edit-family-members branch June 4, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants