-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra data typ checks #111
Conversation
Signed-off-by: Jan Maarten van Doorn <52956303+JanMaartenvanDoorn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to add these checks to enforce the right types!
I am missing some tests for the added code. However, adding tests will probably be a hassle, since the existing code you are expanding on is not written in a testable way. So, I leave the decision to you whether or not you want to add some testing.
Co-authored-by: Martijn Cazemier <37078892+MartijnCa@users.noreply.github.com> Signed-off-by: Jan Maarten van Doorn <52956303+JanMaartenvanDoorn@users.noreply.github.com>
Co-authored-by: Martijn Cazemier <37078892+MartijnCa@users.noreply.github.com> Signed-off-by: Jan Maarten van Doorn <52956303+JanMaartenvanDoorn@users.noreply.github.com>
No description provided.