Update data_interface.py #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Kreuwel <frank.kreuwel@alliander.com>
|
I also do not know if this will fix the issue. However, your suggstion to test using a pre-release is to me a very good idea! |
bartpleiter
approved these changes
Jan 3, 2024
Signed-off-by: Frank Kreuwel <frank.kreuwel@alliander.com>
use new auth for pypi Signed-off-by: Frank Kreuwel <frank.kreuwel@alliander.com>
Signed-off-by: Frank Kreuwel <frank.kreuwel@alliander.com>
Signed-off-by: Frank Kreuwel <frank.kreuwel@alliander.com>
Signed-off-by: Frank Kreuwel <frank.kreuwel@alliander.com>
Signed-off-by: Frank Kreuwel <frank.kreuwel@alliander.com>
Signed-off-by: Frank Kreuwel <frank.kreuwel@alliander.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix:
Replacing None with empty dict is not needed and causes issues, pd.read_sql can deal with params=None.
I did not test if this actually resolves the issue. Maybe we can make a pre-release, include that in a fix-branch of icarus-forecasts and see if that resolves the issue?
Update; the pre-release works:
Bumping it to a proper version an releasing.