Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

149 low level methods arguments in high level methods arguments #150

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

149 low level methods arguments in high level methods arguments #150

wants to merge 6 commits into from

Conversation

maxi-fort
Copy link
Collaborator

@maxi-fort maxi-fort commented May 17, 2024 •
edited
Loading

This pull request will enable more flexibility to high level methods :

  • forecast resolution (15min by default)
  • weather forecast source (optimum by default)
  • country (NL by default)
  • market price (APX by default)
    ...

Once merged, new developpements in openSTEF tasks will allow to use different configurations

@maxi-fort
Adding low level method arguments to services
fe75d01 
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
@maxi-fort
adding forecast_resolution and source to splitting
33fb602 
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
@maxi-fort
adding forgotten resolution argument to get_weather_data from get_win…
ffe97ce 
…d_ref

Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
@maxi-fort maxi-fort added the enhancement New feature or request label May 17, 2024
@maxi-fort
replacing position argument with keyword argument
242d2bb 
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
@maxi-fort
black reformatting
08e630b 
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
@maxi-fort
adding market price argument
302d890 
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
bartpleiter
bartpleiter approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@bartpleiter bartpleiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! Good to have more flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartpleiter bartpleiter bartpleiter approved these changes

@clara-de-smet clara-de-smet Awaiting requested review from clara-de-smet

Assignees

@bartpleiter bartpleiter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxi-fort @bartpleiter