correct hasSaleEnded #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonklein
reviewed
Nov 3, 2017
contracts/TokenSale.sol
Outdated
| // and endtime has past, then sale has ended | ||
| } else if (pausedTime == 0 && currentTime() >= endTime) { | ||
| return true; | ||
| // otherwise it not past and not paused; or paused |
There was a problem hiding this comment.
Suggest adding "is": "... otherwise it is not past and not paused ..."
contracts/TokenSale.sol
Outdated
| // otherwise it not past and not paused; or paused | ||
| // and as such not ended | ||
| } else { | ||
| return false; |
There was a problem hiding this comment.
Now that hasSaleEnded will return false if the sale is paused and we have past the original endTime, updateWhitelist should probably stet require(!hasSaleEnded()), because otherwise the whitelist can be updated after the sale ends but before it is finalized.
Thoughts?
There was a problem hiding this comment.
Great point; will make said changes.
…WhiteList to not-hasSaleEnded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct
hasSaleEndedto correct for paused, but not yet ended sale condition