Patch About page randomization bug #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moteanup24 is attempting to deploy a commit to the OpenSats Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dergigi
approved these changes
Nov 28, 2023
| }) | ||
|
|
||
| let members | ||
| switch (subset) { |
There was a problem hiding this comment.
Nice! I like that.
Note that there's also the design team, see DesignTeam.tsx which is included as an MDX component in https://opensats.org/nostr#nostr-design - but I'd say that's a story for a follow-up PR.
| export default function Members({ subset }) { | ||
| const [sortedMembers, setSortedMembers] = useState([...allAuthors]) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I guess useEffect is what did the trick 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dergigi this did the trick for me (I was able to retain the randomization functionality), please let me know if you still have issues with this bug!
note: this also includes some refactoring and cleaning up of outdated code