Fixing a bug: setParameter backward compatibility issue after recent commit #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mhscott here's the PR related to the issue #1072
After the recent commit b15a2e5, the ElementStateParameter was added to the domain the first time with a tag = 0.
The second time "setParameter" is called, it will be ignored because a parameter with tag = 0 already exists.
However, it also generated a seg-fault in the wipeModel, because the ElementStateParameter was added to the domain, but in the setParameter command, the ElementStateParameter is passed as a pointer to a temporary.
Now it is fixed (in both Python and Tcl) just by:
To do so, however, I had to do a minor change to the ElementStateParameter class, because it did not accept a tag in the constructor