V4.2.x upstream #110
Merged
V4.2.x upstream #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent to wearReciever. Entered debug phase of connection
Fixing multiple startcommand
here most fore change is checking broadcast receiver up to registered intend for sd server receiving end.
Tracking mToneGenerator in onDestroy of SdServer to be nonNull and then release The Same for mNetworkBroadcastReceiver.
…nd mSdData.haveSettings
Further building test; using Junit5 (jupiter) Again shifting shared preferencest to Androidx in SdServer Rejecting null aWIntentBase in SdDataSourceAw.onStartReceived setting mSdData.mHRAlarmActive in SdDataSource on condition Source is not Phone
Further building test; using Junit5 (jupiter) Again shifting shared preferencest to Androidx in SdServer Rejecting null aWIntentBase in SdDataSourceAw.onStartReceived setting mSdData.mHRAlarmActive in SdDataSource on condition Source is not Phone Connecting PowerUpdate into SdDataSourcePhone. Attempt in closing issue.
…spend in SdDataSourceAw
|
Thanks - I'll merge it and try it out. |
|
Well, it is running without crashing on the emulator using the Phone data source, which is good :) |
|
That Server destruction is exactly an issue where i'm diving into.
The delay of finishing StartupActivity is in when is the first set of
mSampleCount satisfied. Maybe I add a message on the first received sensor
values.
This night I've been running with a extra off body sensor de- reactivation.
Next step is maybe a subtle beep from the phone, notification displayed and
MainActivity showing not worn.
Battery life increased big time
Op za 1 jul. 2023 22:45 schreef Graham Jones ***@***.***>:
… Well, it is running without crashing on the emulator using the Phone data
source, which is good :)
StartUpActivity seems to work correctly (it seemed to take longer to
receive data than I thought it should, but that could be an emulator issue).
...but once StartUpActivity exits and MainActivity starts, SdServer shuts
down for some reason. MainActivity still says Server Running OK, but the
task bar notification disappears and I can see it has called onDestroy in
logcat.
—
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV6J743RK7XGQPPK2ZDD6MDXOCD67ANCNFSM6AAAAAAZ2ZMKXQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Watch battery life in this case
Op zo 2 jul. 2023 09:52 schreef Bram Regtien ***@***.***>:
… That Server destruction is exactly an issue where i'm diving into.
The delay of finishing StartupActivity is in when is the first set of
mSampleCount satisfied. Maybe I add a message on the first received sensor
values.
This night I've been running with a extra off body sensor de- reactivation.
Next step is maybe a subtle beep from the phone, notification displayed
and MainActivity showing not worn.
Battery life increased big time
Op za 1 jul. 2023 22:45 schreef Graham Jones ***@***.***>:
> Well, it is running without crashing on the emulator using the Phone data
> source, which is good :)
> StartUpActivity seems to work correctly (it seemed to take longer to
> receive data than I thought it should, but that could be an emulator issue).
> ...but once StartUpActivity exits and MainActivity starts, SdServer shuts
> down for some reason. MainActivity still says Server Running OK, but the
> task bar notification disappears and I can see it has called onDestroy in
> logcat.
>
> —
> Reply to this email directly, view it on GitHub
> <#110 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AV6J743RK7XGQPPK2ZDD6MDXOCD67ANCNFSM6AAAAAAZ2ZMKXQ>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
It might be a race condition doing the connection to the server. |
|
Ow yeah That is one thing I noticed. At my part I take it out, because an
UI has an prohibition in invoking a wait.
The mHandler.post is invoked, the function wait finishes, where the
Runnable is invoked after the delay expires.
Here does the connect not get invoked after.
If we place the connect inside the wait after boolean isServerRunning is
true, it might work.
Op zo 2 jul. 2023 14:22 schreef Graham Jones ***@***.***>:
… It might be a race condition doing the connection to the server.
I wonder if my waitForConnection works properly - if that did not really
wait, what would happen?
(
https://github.com/OpenSeizureDetector/Android_Pebble_SD/blob/V4.2.x/app/src/main/java/uk/org/openseizuredetector/MainActivity.java#L483
)
—
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV6J747CZIZQYFHYNP6ZMLTXOFRY5ANCNFSM6AAAAAAZ2ZMKXQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to pull in state until 230701.
Includes to check for closure of reported issues.