Gitlab-ci: Update Windows builder configs #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This matters on Windows, as it controls where the DLL files end up. (They belong in the same directory as .exe files.)
- The 32-bit MinGW install now lives at `C:\msys64\mingw32\` - All multi-arch binaries are expected to be in one of the MinGW subdirs, either `C:\msys64\mingw32` or `C:\msys64\mingw64` (The shell's `$env:Path` is set accordingly.) - Use "MinGW Makefiles" generator, primarily because it automatically sets the correct CMAKE_MAKE_PROGRAM.
- The Linux builder's CMake is too old to install targets from a parent directory. - target_compile_definitions() is not the same thing as target_compile_options()
- The Linux builder's CMake is too old to install targets from a parent directory. - target_compile_definitions() is not the same thing as target_compile_options()
|
Merging this as well, to start getting the Windows builders back on track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (which actually also contains #118, a prerequisite) updates the project's Windows builder configs in
.gitlab-ci.ymlfollowing changes / enhancements to the MSYS2-managed MinGW32 and MinGW64 build environment(s).The changes of real interest are all described at #118.