CMake: Correct EXPORTED config install path #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdnyc
added
the
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was steered wrong, and set up the
OpenShotAudioConfig.cmakefile (and friends) to install toshare/cmake/... that path is OK for arch-independent installs, but not for architecture-bound library installs likelibopenshot-audio. Those should go into the same${CMAKE_INSTALL_LIBDIR}that the libraries themselves go into, so that a multi-arch system can simultaneously have, e.g.:/usr/lib/cmake/OpenShotAudio/OpenShotAudioConfig.cmakepointing to a 32-bit version/usr/lib64/cmake/OpenShotAudio/OpenShotAudioConfig.cmakepointing to a 64-bit version...and the right one will be used automatically.
Looking to merge this as soon as the CI is ready, because it has to be coordinated with a corresponding change to the Ubuntu PPA packaging control files (as they expect files to be installed into this path, by name).