Upgrade JUCE to 5.4.7 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, hey, I wonder if this works with the upgraded Mac builder now? I should poke it and see. |
- linux => linux-bionic - Newer macOS SDK attempt - cmake commands for configure/build/install steps on Win/Mac (Linux cmake is too old)
|
After some tweaks to the Gitlab builder script, this builds successfully. It looks like it might be possible to merge this now. Setting up |
|
Merging this, now that the Gitlab libopenshot build should be compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest release.
This still won't build on the Gitlab Mac builder until it's upgraded (see the 5.4.5 upgrade PR, #77), but since there were several fixes to macOS compatibility in the subsequent JUCE 5.4.6 release, it makes sense to target this version rather than that one, for whenever we are able to upgrade.The Mac builder is now compatible with this JUCE version. (As is the Linux builder, now that I've switched it to Bionic. GCC 4.8 is no longer a viable compiler, since it doesn't have full C++11 support.)