Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stale bot for github issue management (libopenshot-audio) #93

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Mar 9, 2020

Experimental support for stale plugin, to help with issue management on GitHub. https://github.com/marketplace/stale

Related PR for libopenshot: OpenShot/libopenshot#460

@jonoomph jonoomph changed the title Adding stale bot for github issue management Adding stale bot for github issue management (libopenshot-audio) Mar 9, 2020
@jonoomph
Copy link
Member Author

jonoomph commented Mar 9, 2020

@ferdnyc Would love to hear your comments on default settings. These are mostly the "default" settings the stale bot ships with. I think 60 days seems fair, before tagging an issue as 'stale', and 7 more days to respond also seems reasonable.

I'm not quite sure what happens though, after someone responds. Does the bot remove the 'stale' label automatically?

@ferdnyc
Copy link
Contributor

ferdnyc commented Mar 10, 2020

@ferdnyc Would love to hear your comments on default settings. These are mostly the "default" settings the stale bot ships with. I think 60 days seems fair, before tagging an issue as 'stale', and 7 more days to respond also seems reasonable.

Yeah, that sounds pretty fair. Might want to raise it to 120 or even 180 days on these repos, since issues tend to languish a lot longer despite being perfectly valid. But for OpenShot, 2 months sounds reasonable.

Maybe the grace period could be raised to 2 weeks, since there actually have been plenty of times where someone's gotten back to an issue (in either direction) after 10 or 12 days have passed... but 7 is probably fine, too.

I'm not quite sure what happens though, after someone responds. Does the bot remove the 'stale' label automatically?

According to the marketplace listing, yes. 👍

If the Issue or Pull Request is updated, or anyone comments, then the stale label is removed.

Only change I'd request, for all repos, is to add exemptAssignees: true to the config, so that assigning an issue to someone will protect it from being Stale'd.

Oh, that, and only: issues, if it isn't already set, since we definitely don't want pull requests to get auto-closed after only 2 months. Or probably ever, really. We can manually close those, there's not that many.

@jonoomph
Copy link
Member Author

@ferdnyc Updating auto-stale conditions (90 days warning, 10 days to respond, only issues, ignore assigned issues). I feel good about these changes. I'm gonna merge this soon, and see what happens. 🤞

@ferdnyc
Copy link
Contributor

ferdnyc commented Mar 11, 2020

LGTM. Hell, I'll pull the trigger for you, let's light this candle. 😉

@ferdnyc ferdnyc merged commit 232f3f7 into develop Mar 11, 2020
@ferdnyc
Copy link
Contributor

ferdnyc commented Mar 11, 2020

(You'll notice I only did the one repo, because I am a coward. We'll see how this goes...)

@ferdnyc
Copy link
Contributor

ferdnyc commented Mar 11, 2020

Oh, hehe, see? The parameters are already out of sync. I have to update the description of the stale label, to reflect the latest changes. 😄

@jonoomph jonoomph deleted the stale-bot branch March 11, 2020 01:31
@jonoomph
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants