Skip to content

Commit

Permalink
Fixed ObjectDetection crash (disabled effect parenting)
Browse files Browse the repository at this point in the history
  • Loading branch information
BrennoCaldato committed Apr 9, 2021
1 parent 6b6b6d5 commit 1e32ef8
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions src/EffectBase.cpp
Expand Up @@ -132,12 +132,16 @@ void EffectBase::SetJsonValue(Json::Value root) {
// Get the list of effects on the timeline
std::list<EffectBase*> effects = parentTimeline->ClipEffects();

// Loop through the effects
for (auto const& effect : effects){
// Set the properties of all effects which parentEffect points to this
if (effect->info.parent_effect_id == this->Id())
effect->SetJsonValue(root);
}
// TODO: Fix recursive call for Object Detection

// // Loop through the effects and check if we have a child effect linked to this effect
// for (auto const& effect : effects){
// // Set the properties of all effects which parentEffect points to this
// if ((effect->info.parent_effect_id == this->Id()) && (effect->Id() != this->Id()))
// std::cout<<"passou3 \n";

// effect->SetJsonValue(root);
// }
}

// Set this effect properties with the parent effect properties (except the id and parent_effect_id)
Expand Down Expand Up @@ -218,5 +222,5 @@ std::string EffectBase::ParentClipId() const{
if(clip)
return clip->Id();
else
return "None";
return "";
}

0 comments on commit 1e32ef8

Please sign in to comment.