Apply suggestions from code review

Co-authored-by: Frank Dana <ferdnyc@gmail.com>
OpenShot · Jan 12, 2021 · e19c931 · e19c931
1 parent 49097ce
commit e19c931
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/effects/Stabilizer.h b/src/effects/Stabilizer.h
@@ -95,9 +95,9 @@ namespace openshot
 		Keyframe zoom;
 
 	public:
-	std::string teste;
-        std::map <size_t,EffectCamTrajectory> trajectoryData; // Save camera trajectory data
-    	std::map <size_t,EffectTransformParam> transformationData; // Save transormation data 
+		std::string teste;
+		std::map <size_t,EffectCamTrajectory> trajectoryData; // Save camera trajectory data
+		std::map <size_t,EffectTransformParam> transformationData; // Save transormation data 
 
 		/// Blank constructor, useful when using Json to load the effect properties
 		Stabilizer(std::string clipTrackerDataPath);
@@ -119,7 +119,7 @@ namespace openshot
 		std::shared_ptr<openshot::Frame> GetFrame(int64_t frame_number) override { return GetFrame(std::shared_ptr<Frame> (new Frame()), frame_number); }
 
 		// Load protobuf data file
-        bool LoadStabilizedData(std::string inputFilePath);
+		bool LoadStabilizedData(std::string inputFilePath);
 
 		/// Get and Set JSON methods
 		std::string Json() const override; ///< Generate JSON string of this object

diff --git a/src/effects/Tracker.h b/src/effects/Tracker.h
@@ -92,7 +92,7 @@ namespace openshot
 
 	public:
 
-        std::map<int, EffectFrameData> trackedDataById; // Save object tracking box data
+		std::map<int, EffectFrameData> trackedDataById; // Save object tracking box data
 
 		/// Blank constructor, useful when using Json to load the effect properties
 		Tracker(std::string clipTrackerDataPath);
@@ -113,10 +113,10 @@ namespace openshot
 		std::shared_ptr<openshot::Frame> GetFrame(int64_t frame_number) override { return GetFrame(std::shared_ptr<Frame> (new Frame()), frame_number); }
 
 		// Load protobuf data file
-        bool LoadTrackedData(std::string inputFilePath);
+		bool LoadTrackedData(std::string inputFilePath);
 
 		// Get tracker info for the desired frame 
-        EffectFrameData GetTrackedData(size_t frameId);
+		EffectFrameData GetTrackedData(size_t frameId);
 
 		/// Get and Set JSON methods
 		std::string Json() const override; ///< Generate JSON string of this object

diff --git a/src/sort_filter/KalmanTracker.cpp b/src/sort_filter/KalmanTracker.cpp
@@ -19,7 +19,8 @@ void KalmanTracker::init_kf(
 
 	measurement = Mat::zeros(measureNum, 1, CV_32F);
 
-	kf.transitionMatrix = (Mat_<float>(stateNum, stateNum) << 1, 0, 0, 0, 1, 0, 0,
+	kf.transitionMatrix = (Mat_<float>(7, 7) << 1, 0, 0, 0, 1, 0, 0,
+
 						   0, 1, 0, 0, 0, 1, 0,
 						   0, 0, 1, 0, 0, 0, 1,
 						   0, 0, 0, 1, 0, 0, 0,