Streamline and parallelize Wave effect #425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You know the drill by now. Main
for()
loop decorated with#pragma omp parallel for
, and streamlined for cleaner parallelization.In this one I also eliminated an unnecessary copy of the frame image data, taking advantage of QImage's implicit data sharing and automatic copying functionality to use the frame image's
constBits()
as the source pixel data, and (an implicitly-copied)bits()
as the destination.11-second Big Buck Bunny clip export time on my 4-core system:
28s
, down from1m24s
(nearly 3x as fast).