Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline and parallelize Wave effect #425

Merged
merged 1 commit into from Feb 27, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Feb 3, 2020

You know the drill by now. Main for() loop decorated with #pragma omp parallel for, and streamlined for cleaner parallelization.

In this one I also eliminated an unnecessary copy of the frame image data, taking advantage of QImage's implicit data sharing and automatic copying functionality to use the frame image's constBits() as the source pixel data, and (an implicitly-copied) bits() as the destination.

11-second Big Buck Bunny clip export time on my 4-core system: 28s, down from 1m24s (nearly 3x as fast).

@ferdnyc ferdnyc mentioned this pull request Feb 3, 2020
@codecov-io
Copy link

Codecov Report

Merging #425 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #425   +/-   ##
========================================
  Coverage    42.37%   42.37%           
========================================
  Files          129      129           
  Lines        13276    13276           
========================================
  Hits          5626     5626           
  Misses        7650     7650
Impacted Files Coverage Δ
src/effects/Wave.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49972b2...7d2ff3a. Read the comment docs.

@jonoomph
Copy link
Member

LGTM! Nice work!

@jonoomph jonoomph merged commit 4fc9e9d into OpenShot:develop Feb 27, 2020
@ferdnyc ferdnyc deleted the optimized-wave branch February 28, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants