Saturation: streamline and parallelize #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #428 +/- ##
===========================================
+ Coverage 42.37% 42.39% +0.01%
===========================================
Files 129 129
Lines 13276 13270 -6
===========================================
Hits 5626 5626
+ Misses 7650 7644 -6
Continue to review full report at Codecov.
|
|
I love these optimizations, so long as they don't crash on systems. 👍 |
|
I love them even if they crash! #LivingDangerously (Besides, crashes can be fixed. 👼 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again, Saturation was fairly efficient already, but adding
#pragma omp parallel forand eliminating some intermediate variable storage allows it to run roughly twice as fast on my system, and I would expect even better results from a more powerful CPU.