Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorShift effect: Don't init with random values #443

Merged
merged 1 commit into from Feb 27, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Feb 13, 2020

For no discernible reason, the Color Shift effect initializes itself with the following properties:

Property Value
Alpha X Shift 0.00
Alpha Y Shift 0.00
Red X Shift -0.05
Red Y Shift 0.00
Green X Shift 0.05
Green Y Shift 0.00
Blue X Shift 0.00
Blue Y Shift 0.00

The random "defaults" are arbitrary and unnecessary, and just complicate management of the effect parameters. This PR loses them, and inits all of the shifts to 0.00.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 13, 2020

(Note: This change won't affect existing projects, since all property values are exported directly into the project file — only newly-added instances of ColorShift will use different initial property values.)

@jonoomph
Copy link
Member

I think the intention on the initial values was to "show" a difference when the effect was applied. But I can understand how this is not expected, lol.

@jonoomph jonoomph merged commit bc6c9fd into OpenShot:develop Feb 27, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 28, 2020

I think the intention on the initial values was to "show" a difference when the effect was applied.

Yeah, and I get that — with some effects, it makes a lot of sense, because they have some sort of linear adjustment that can be defaulted to some "does its thing" point along that linear scale. But these defaults just felt so arbitrary and weird, even relative to the other effects' arbitrary/weird defaults. 😆

@ferdnyc ferdnyc deleted the colorshift-init branch June 2, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants