bindings: Relative paths, overridable #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdnyc
added
the
build
Codecov Report
@@ Coverage Diff @@
## develop #458 +/- ##
========================================
Coverage 43.22% 43.22%
========================================
Files 130 130
Lines 12932 12932
========================================
Hits 5590 5590
Misses 7342 7342Continue to review full report at Codecov.
|
|
If the Gitlab builders like this, I'm probably going to merge it along with #469, so the bindings can stop being a pain point in our build/install process. |
|
Everything wound up where it was meant to, on all four platforms. Merging. |
This was referenced Mar 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the install paths for the bindings files, in particular the Ruby bindings which have been installing to an absolute path (which causes problems when building as non-root). In addition, the Gitlab builder scripts were moving Python artifacts from their installed locations to
${CMAKE_INSTALL_PREFIX}/python, which is just silly.Now,
PYTHON_MODULE_PATHorRUBY_MODULE_PATHcan be defined on the CMake command line, and they'll override the detection process. (They're interpreted relative to the install prefix, so just-DPYTHON_MODULE_PATH=pythonrecreates the previous scripted output.In addition, the module paths on Windows and MacOS default to simply "python" or "ruby" instead of bothering with detection, since we don't install on the system there anyway.