Adding ability for a Clip to auto-detect and instantiate a Timeline Reader #459
Conversation
…eader from the *.osp file type. Added new Timeline constructor, to auto load UTF-8 JSON file, and regex convert all paths to absolute. Fixed a dead lock issue when a Timeline loads another Timeline.
There was a problem hiding this comment.
Appreciate all the feedback! @ferdnyc, the \2 makes a ton of sense now! Unfortunately, it's not as pretty to loop through the matches, but I think it's needed at this point. Take a look at the latest code I just pushed here.
- It gets a list of matches of all "image" or "path" paths... much simpler one than before
- Adds the matches to a vector, ughh, so I can get a reverse iterator (Qt regex matches have no way to be reversed I guess... not that I could find)
- Loop backwards through the match vector, converting paths and replacing strings as I go
I still believe this is quite good on performance, at least with my large project files I've been testing, it's basically instantaneous. And now I'm using the canonicalFilePath() method correctly, with fully exploded paths, and everything works much better.
It supports @assets, @transitions, ../, ../../, ../../../, ./FileName, etc... I can now import any *.osp project on my computer into OpenShot, and drop it on the timeline like any other file. Pretty nuts!
|
Oh, and I accidentally started a "review" on this PR, and it's threatening me that if I cancel the review, it will delete all our comments. So... hmmm, I'm gonna just ignore it. 😉 |
The review functionality gets really weird once reviews have been started on a PR, I've noticed — even normal conversational replies like this one can end up being submitted as reviews, and that's apparently just the way it's meant to work. It's thrown me a few times too, though. Whenever it starts going on about reviews, I just submit everything that way, and it seems to work out.
|
|
Merging, excited about this one! |
Adding ability for a Clip to auto-detect and instantiate a Timeline Reader from the *.osp file type. Added new Timeline constructor, to auto load UTF-8 JSON file, and regex convert all paths to absolute. Fixed a dead lock issue when a Timeline loads another Timeline.
This is the first big step towards allowing multiple *.osp files to exist inside an OpenShot Project. This opens up an infinite number of cool possibilities, such as splitting projects into scenes, and then combining scenes at the end. Or importing templates (i.e. *.osp projects) with the complexity hidden from the user (since it looks like a normal clip). I have big plans for this soon!!!
However, performance seems suspect currently, and we'll need to dig deeper, and determine how to most efficiently set thread limits and cache limits for nested Timeline readers.