Various: Remove unused variables #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdnyc
force-pushed
the
unused-var-sweep
branch
from
0cfde3e
to
7bb122f
Compare
|
Whoops, missed |
ferdnyc
force-pushed
the
unused-var-sweep
branch
2 times, most recently
from
a490955
to
89e774b
Compare
Several data members and local variables were flagged by static analysis tools as never being used anywhere in the code.
ferdnyc
force-pushed
the
unused-var-sweep
branch
from
89e774b
to
9be6a9a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #467 +/- ##
===========================================
+ Coverage 48.04% 48.05% +<.01%
===========================================
Files 128 128
Lines 9941 9933 -8
===========================================
- Hits 4776 4773 -3
+ Misses 5165 5160 -5
Continue to review full report at Codecov.
|
|
They're unused, it's right in the name. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate several data members and local variables across the codebase, because they were flagged by static analysis tools as never being used anywhere in the code. First part of my massive clazy/Codacy cleanup sweep.
Also, the
src/bindings/ruby/test.rbfile is renamed tosrc/examples/Example.rb. I hadn't intended to include that in this PR, but it makes sense so I'll leave it.