Clip_Tests: Remove try/catch blocks #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnitTest++ has its own exception handling (you can even
CHECK_THROW()
to test that a call throws an exception as expected), so the try/catch blocks in the Clip unit tests serve no purpose except to add unreachable code.This PR replaces them with
REQUIRE CHECK_EQUAL(true, success);
checks on the result var from the previous call (the one that, when it was found false, the test used tothrow()
).