Replace sleep()/usleep() with std::chrono calls #473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates all remaining calls to
sleep()
andusleep()
in the library (except in the Decklink files; I don't mess with those). In both C and C++,sleep()
andusleep()
are considered obsolete, and will be flagged as a potential security issue by many static analysis tools, due to their poor interaction with things likeSIGALRM
.In C++11, the
std::this_thread::sleep_for()
STL class provides a feature-rich replacement.(This is only a stopgap measure, as it would be better to eliminate these sleeps entirely. Sleeping is generally inadvisable — it's better to use timers or waitables. Here's Jules, the JUCE developer railing against the use of
sleep()
to delay program execution.)