Transform Improvements (Keyframe origin point) #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #496 +/- ##
========================================
Coverage 48.24% 48.24%
========================================
Files 128 128
Lines 9962 9972 +10
========================================
+ Hits 4806 4811 +5
- Misses 5156 5161 +5
Continue to review full report at Codecov.
|
SuslikV
reviewed
Apr 23, 2020
| transform.translate(x, y); | ||
| transformed = true; | ||
| } | ||
| if (!isEqual(r, 0) || !isEqual(shear_x, 0) || !isEqual(shear_y, 0)) { |
There was a problem hiding this comment.
This code has related issue: OpenShot/openshot-qt#2794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding keyframable origin point (for shear and rotation). Used in OpenShot/openshot-qt#3366. Both rotation and shear use an origin point to control how those tools work. This allows the user to not only set a custom origin point (as a % of the original clip), but it allows the origin to be animated, which allows for some really great animations!
origin_x: 0.0 = left side of clip
origin_x: 1.0 = right side of clip
origin_y: 0.0 = top side of clip
origin_y: 1.0 = bottom side of clip