Rename our BaseException class to ExceptionBase, for Python #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseException is a python standard library exception class, so it's not a great idea to redefine that name in our bindings. Renamed to ExceptionBase, which is more in keeping with our class naming system anyway.
ferdnyc
added
code
|
This is pretty minor, and it's best if we avoid name clashes in Python. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylintpointed out thatBaseExceptionis a Python standard library exception class (not quite a reserved word, but pretty close), so it's not a great idea to redefine that name in our bindings.This PR renames it to
ExceptionBase, which is actually more in keeping with our standard class naming system anyway. (CompareReaderBase,EffectBase,CacheBase, etc.)