Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pixelate filter scale #507

Merged
merged 1 commit into from Sep 10, 2020
Merged

Conversation

SuslikV
Copy link
Contributor

@SuslikV SuslikV commented Apr 27, 2020

Fixes: #506

@codecov-io
Copy link

Codecov Report

Merging #507 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #507      +/-   ##
===========================================
- Coverage    48.25%   48.23%   -0.02%     
===========================================
  Files          128      128              
  Lines         9954     9957       +3     
===========================================
  Hits          4803     4803              
- Misses        5151     5154       +3     
Impacted Files Coverage Δ
src/effects/Pixelate.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c3efb...4f60f45. Read the comment docs.

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 28, 2020

This looks pretty good to me, though I haven't tested it very thoroughly yet.

Sorry, I got bogged down when I started testing with the discovery that I screwed up the implementation of the effect borders, which seem to be pretty much broken on two sides. (Top, for sure.)

I'm having a bear of a time getting it to work right, QRect and QPainter seem to be having these weird, nondeterministic interactions. Decided to leave it alone for now and come back to it tomorrow.

@jonoomph jonoomph merged commit ce491a0 into OpenShot:develop Sep 10, 2020
@SuslikV SuslikV deleted the pix-new-scale branch October 4, 2020 17:39
@SuslikV SuslikV restored the pix-new-scale branch November 15, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pixelization = 1,0 does not pixelate at all
4 participants