Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Switch to Ubuntu 20.04 Focal for FFmpeg 4 build #522

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jun 1, 2020

Travis appear to have quietly brought up Ubuntu Focal as an available build dist (still undocumented anywhere, AFAICT). Still, using an undocumented Travis environment is the lesser evil, vs. using FFmpeg packages from a community PPA that's already bailed on us once.

@ferdnyc ferdnyc added the build Issues related to compiling or installing libopenshot and its dependencies label Jun 1, 2020
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #522 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #522   +/-   ##
========================================
  Coverage    48.33%   48.33%           
========================================
  Files          128      128           
  Lines         9962     9962           
========================================
  Hits          4815     4815           
  Misses        5147     5147           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4567154...511a6b1. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jun 2, 2020

Merging this, as it allows us to eliminate all community/unofficial PPA usage (except our own!) in the CI setup, other than the FFmpeg 3.2 problem-child which remains in limbo ATM.

Travis's Focal support isn't likely to go away now that they've let that genie out of its bottle, I'm sure it'll become official soon enough.

cc: @jonoomph

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jun 2, 2020

FFmpeg 3.2 will probably just end up getting dropped. Adding it as a test version in #435 was a "nice to have", after #433 revealed some issues with code that was claimed to be FFmpeg 3.2 compatible but actually required 3.4... but it was never critical. Those are both outdated versions not worth expending resources on.

When adding 3.2 was simple, it made sense. No longer simple? No longer makes sense.

@ferdnyc ferdnyc merged commit 782d764 into OpenShot:develop Jun 2, 2020
@ferdnyc ferdnyc deleted the travis-focal-build branch June 2, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to compiling or installing libopenshot and its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant