Improvements to handling of new codecs #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #525 +/- ##
===========================================
+ Coverage 48.30% 48.79% +0.48%
===========================================
Files 128 129 +1
Lines 9967 10034 +67
===========================================
+ Hits 4815 4896 +81
+ Misses 5152 5138 -14
Continue to review full report at Codecov.
|
jonoomph
reviewed
Jun 15, 2020
jonoomph
reviewed
Jun 15, 2020
Thanks for fixing that Co-authored-by: Jonathan Thomas <jonathan@openshot.org>
Perfect. I forgot that comment. Co-authored-by: Jonathan Thomas <jonathan@openshot.org>
jonoomph
reviewed
Jun 15, 2020
jonoomph
reviewed
Jun 15, 2020
jonoomph
reviewed
Jun 15, 2020
I should take more care of the comments. Co-authored-by: Jonathan Thomas <jonathan@openshot.org>
Co-authored-by: Jonathan Thomas <jonathan@openshot.org>
We might want to leave some kind of comment though. The encoders will (probably) get these options (soon). Co-authored-by: Jonathan Thomas <jonathan@openshot.org>
jonoomph
reviewed
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New codec are now handled better, i.e. libaom-av1 has now settings that allow a usable encoding speed. The settings for rav1e and svt-av1 were adjusted to.
When a bitrate is selected, which is not supported by the av1 encoders (yet), a reasonable quality setting is chosen.