Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the field order when interlace is on #534

Merged
merged 6 commits into from Oct 16, 2020

Conversation

eisneinechse
Copy link
Collaborator

The field order of the interlaced frames is set. This is only a very rude version.
More work needs to be done

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #534 into develop will decrease coverage by 0.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #534      +/-   ##
===========================================
- Coverage    49.37%   48.76%   -0.61%     
===========================================
  Files          129      129              
  Lines        10198    10038     -160     
===========================================
- Hits          5035     4895     -140     
+ Misses        5163     5143      -20     
Impacted Files Coverage Δ
src/FFmpegWriter.cpp 62.29% <0.00%> (-0.04%) ⬇️
src/Timeline.cpp 38.70% <0.00%> (-2.38%) ⬇️
src/Clip.cpp 39.72% <0.00%> (-0.58%) ⬇️
src/Frame.cpp 47.70% <0.00%> (ø)
include/Clip.h 88.88% <0.00%> (ø)
src/CacheDisk.cpp 71.69% <0.00%> (ø)
src/ZmqLogger.cpp 29.33% <0.00%> (ø)
include/FrameMapper.h 75.00% <0.00%> (ø)
src/Qt/PlayerDemo.cpp 0.00% <0.00%> (ø)
src/Qt/PlayerPrivate.cpp 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c35e55...47fca02. Read the comment docs.

@eisneinechse eisneinechse changed the title (WIP) Set the field order when interlace is on Set the field order when interlace is on Jul 7, 2020
@jonoomph
Copy link
Member

LGTM

@jonoomph jonoomph merged commit 7f08778 into OpenShot:develop Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants