Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MagickUtils: Add #pragma to silence IM6 warning #535

Merged
merged 1 commit into from Jun 18, 2020
Merged

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jun 18, 2020

Stupid ImageMagick 6 has a code boner in its header files that produces warning messages at every #include, if -Wextra is enabled during build:

In file included from /usr/include/ImageMagick-6/magick/memory_.h:22,
                 from /usr/include/ImageMagick-6/magick/MagickCore.h:125,
                 from /usr/include/ImageMagick-6/Magick++/Include.h:45,
                 from /usr/include/ImageMagick-6/Magick++.h:10,
                 from /home/ferd/rpmbuild/REPOS/libopenshot/worktree-valgrind/include/Qt/../MagickUtilities.h:39,
                 from /home/ferd/rpmbuild/REPOS/libopenshot/worktree-valgrind/include/Qt/../Frame.h:56,
                 from /home/ferd/rpmbuild/REPOS/libopenshot/worktree-valgrind/include/Qt/../RendererBase.h:34,
                 from /home/ferd/rpmbuild/REPOS/libopenshot/worktree-valgrind/include/Qt/VideoRenderer.h:34,
                 from /home/ferd/rpmbuild/REPOS/libopenshot/worktree-valgrind/include/Qt/VideoRenderWidget.h:37,
                 from /home/ferd/rpmbuild/REPOS/libopenshot/worktree-valgrind/include/Qt/PlayerDemo.h:41,
                 from /home/ferd/rpmbuild/REPOS/libopenshot/worktree-valgrind/build/src/openshot_autogen/RMFXSSRFNF/moc_PlayerDemo.cpp:10,
                 from /home/ferd/rpmbuild/REPOS/libopenshot/worktree-valgrind/build/src/openshot_autogen/mocs_compilation.cpp:2:
/usr/include/ImageMagick-6/magick/memory_.h: In function ‘MagickCore::MagickBooleanType MagickCore::HeapOverflowSanityCheckGetSize(size_t, size_t, size_t*)’:
/usr/include/ImageMagick-6/magick/memory_.h:98:20: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
   98 |   assert(extent != (size_t *const) NULL);
      |                    ^

...and so on, every time Frame.h is #included. (Which is a lot.) A #pragma disables the not-of-any-use-to-us warning.

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #535 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #535   +/-   ##
========================================
  Coverage    48.79%   48.79%           
========================================
  Files          129      129           
  Lines        10034    10034           
========================================
  Hits          4896     4896           
  Misses        5138     5138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d1689...001b2d8. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jun 18, 2020

Merging as inconsequential, in the grand scheme of things.

@ferdnyc ferdnyc merged commit 517f289 into develop Jun 18, 2020
@ferdnyc ferdnyc deleted the ferdnyc-patch-1 branch June 18, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant