Bitratecorrect #539
Merged
Bitratecorrect #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
for mpeg2. Changing them for the other codecs resultet in exporting with the wrong bitrate.
Codecov Report
@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
- Coverage 48.79% 48.77% -0.02%
===========================================
Files 129 129
Lines 10034 10035 +1
===========================================
- Hits 4896 4895 -1
- Misses 5138 5140 +2
Continue to review full report at Codecov.
|
|
LGTM. Not sure why codecov has an issue though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values for qmax and qmin were set for all codec but only mpeg2 needed them and as a result the bitrates of the exported clips could be wrong. Now only when the export is with mpeg2 the default values are changed.